[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] Update Windows configuration template

From: Pavel Fedin
Subject: [PATCH 2/2] Update Windows configuration template
Date: Fri, 09 Aug 2013 17:40:45 +0400


 This patch fixes up Windows build using .bat files. The two issues are:

1. New compilers have inttypes.h file, current config.h.W32 causes compile
errors because of uintmax_t redefinition (it ends up in attempt to use
something like long long long).
2. Test suite now passes TEMP and TMP variables to Make. By default Windows
version tries to use current drive's root as temporary directory, this makes
it nonfunctional on post-XP systems where elevated admin privilege is
necessary to write to drive's root.

 P.S. I decided to discuss one more issue with you first since i already
know how picky you are. There is a problem in configure script which makes
it impossible to build Windows version under MinGW. The problem is path
separator detection. In MinGW configure scripts are executed using MSYS
environment, which is still (more or less) POSIX, and the test still returns
':' which is plain wrong. Attempt to override it by supplying
PATH_SEPARATOR=';' env variable to configure script completely breaks
configuration process, because the script tries to use this separator
 I suggest to add an explicit case when $host_os = "mingw*" which skips the
test and sets ';' manually (or does not set anything, relying on fallback).

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

Attachment: make-3.82.90-1-update-win32-config.diff
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]