[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated

From: Denis Excoffier
Subject: Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated
Date: Sun, 11 Aug 2013 08:54:25 +0200

On 2013-08-07 10:52, Pavel Fedin wrote:

> Perhaps some more testing would convince you. Actually i have
> sent the new patch to Denis Excoffier (who reported the bug), but he doesn't
> reply for some reason. If there'll be no response for some more time, i'll
> retry posting the patch on Cygwin ML. I just don't want to be too much
> annoying.
I've applied the new patch, together with the patch for the DOS paths, on top of
make-3.99.90 and everything seems OK now. Thanks.

As a user, i would be fully happy if the behavior could be driven by the
MAKE_USE_SPAWN env. var. (and a similar env. var. in case the default is spawn).
Associated command line options would be unnecessary, but perhaps needed for
completeness. The default being configurable with the (Cygwin only, to be 
'--enable-spawn=yes|no' parameter to the ./configure program (default=no of 
I suppose we'll also need that 'make --help' reports its default because it 
cannot be
so easily determined (see e.g. the end of 'tar --help') but you may let this 
to other people. On the other hand, you'll have to provide full documentation 

Please provide something like this as a patch against the HEAD and you'll more
easily convince (i think). Avoid grouping two branches of an #ifdef (eg 
'environ = envp'),
let the maintainers do this (if they prefer to).

After that, it will be time for us to wait for the make-3.99.91 distribution.


Denis Excoffier.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]