make check under Cygwin

[Denis Excoffier]

Still experimenting 'make check' with Cygwin (without the spawn-patch,
with --disable-load):

1) In test_driver.pl, line 486 (look for "Test returned"), a comparison
of $code against the value -1 is performed. However, 3 lines above the 
same
test is done. This looks strange.

I wonder if what is meant couldn't be
elsif ($code != 1 && $code != 0) {
instead of
elsif ($code != 1 && $code != -1) {

2) In connection with (1) above, the category 'default_names' produces
'*** Test returned 0' and this is considered to be $suite_passed = 0
(no deletion of files, no incrementation of categories_passed etc.),
however the category seems to pass since the "ok" string is printed.

If i apply (1) above, all is ok.
I don't understand why this "Test returned 0" does not show up
on other (eg Linux) platforms.

3) If the HOME env var is not set, one of the jobserver tests fails.
Perhaps this test should not be launched if HOME is not set.

4) If i do _not_ apply the following patch:

% type patch
diff -uNr make-3.99.92-original/configure 
make-3.99.92-patched/configure
--- make-3.99.92-original/configure     2013-09-23 06:50:50.000000000 +0159
+++ make-3.99.92-patched/configure      2013-09-25 11:12:37.020859600 +0159
@@ -7817,7 +7817,7 @@
     cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */

-#if !defined _WIN32 && !defined __WIN32__ && !defined __MSDOS__ && 
!defined __EMX__ && !defined __MSYS__ && !defined __CYGWIN__
+#if !defined _WIN32 && !defined __WIN32__ && !defined __MSDOS__ && 
!defined __EMX__ && !defined __MSYS__
 neither MSDOS nor Windows nor OS2
 #endif

%

i obtain the following errors:
- output-sync (8/13 passed)
- recursion (1/2 passed)
- abspath (0/1 passed)
- MAKE (0/1 passed)

5) That's all.


With the spawn-patch installed, the output-sync test fails, but this
is another story i suppose.

Hope this helps,

Regards,

Denis Excoffier.