bug-make
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #16788] 'ORDINARY_MTIME_MAX' macro causes integral constant overflo

From: Eli Zaretskii
Subject: [bug #16788] 'ORDINARY_MTIME_MAX' macro causes integral constant overflow
Date: Tue, 22 Oct 2013 16:09:02 +0000
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Firefox/24.0 
Follow-up Comment #1, bug #16788 (project make):

Paul,

The OP suggests to replace this:

#define ORDINARY_MTIME_MAX ((FILE_TIMESTAMP_S (NEW_MTIME) \
                             << FILE_TIMESTAMP_LO_BITS) \
                            + ORDINARY_MTIME_MIN + FILE_TIMESTAMPS_PER_S - 1)

with this:

#define ORDINARY_MTIME_MAX ((FILE_TIMESTAMP_S (NEW_MTIME) \
                             << FILE_TIMESTAMP_LO_BITS) \
                            + ORDINARY_MTIME_MIN - 1 + FILE_TIMESTAMPS_PER_S)

(in filedef.h).

This looks as a no-brainer to me, so if you don't object, I will make that
change.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?16788>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/
reply via email to
[Prev in Thread] Current Thread [Next in Thread]