Re: [bug #40226] Weird failure on Windows with OUTPUT_SYNC_TARGET

[Eddy Petrișor]

Pe 24.11.2013 11:12, "Paul D. Smith" <address@hidden> a scris:

> I enhanced the option parsing in make to create a new type of option, that
> takes a single string instead of a list of strings.  If multiple instances of
> that option are provided, each subsequent instance overwrites (instead of adds
> to) the previous one.
>
> This new type is used for the jobserver fds internal option, the output-sync
> option, and the sync-mutex option.

For the profiling patch I sent in #40639 a non repeatable simple string would have been better than the stringlist I used.

Since you just worked on this, and the new type overwrites in case of repetition, does it make sense to overwrite instead of error? I think that for profiling this type of behaviour would be better.

The stringlist has the undesired effect that if the option -P without a parameter is passed then another -P with format string, the first one sets the format strong to the default and the second has no effect, which is inconsistent (when all -P options have a format string, they are concatenated).