Re: mingw-w64 build breaks and warnings

[Paul Smith]

On Mon, 2013-11-25 at 19:39 -0800, Stephan T. Lavavej wrote:
> #1:
>            OSN (fatal, NILF,
>            ^

Fixed, thanks.

> #2:
> w32err.c: In function 'map_windows32_error_to_string':
> w32err.c:70:3: warning: passing argument 2 of 'fatal' makes integer from
> pointer without a cast [enabled by default]
>    fatal(NILF, szMessageBuffer);
>    ^

Fixed, thanks.

> Then there is a severe warning:
> 
> #3:
> main.c: In function 'prepare_mutex_handle_string':
> main.c:796:7: warning: format '%x' expects argument of type 'unsigned int',
> but argument 3 has type 'sync_handle_t' [-Wformat=]
>        sprintf (sync_mutex, "0x%x", handle);
>        ^
> 
> Note that this sprintf() is guarded by #ifdef WINDOWS32 above, so we don't
> need to worry about other platforms. Using the MS length modifier, "%Ix"
> will work for both 32-bit and 64-bit builds.

Fixed, thanks.

> #4:
> function.c: In function 'func_shell_base':
> function.c:1625:7: warning: variable 'errfd' set but not used
> [-Wunused-but-set-variable]
>    int errfd;
>        ^

I didn't change anything for this one.  I'll look at it later.

> #5:
> getopt.c: In function '_getopt_internal':
> getopt.c:679:8: warning: suggest explicit braces to avoid ambiguous 'else'
> [-Wparentheses]
>      if (opterr)
>         ^

The getopt() code is taken from glibc, so I don't like to make GNU
make-specific changes there.

> #6:
> job.c: In function 'reap_children':
> job.c:666:9: warning: label 'remote_status_lose' defined but not used
> [-Wunused-label]
>          remote_status_lose:
>          ^

I didn't change anything for this one.  I'll look at it later.

> #7:
> job.c: In function 'construct_command_argv_internal':
> job.c:2667:9: warning: variable 'end' set but not used
> [-Wunused-but-set-variable]
>    char *end;
>          ^

I didn't change anything for this one.  I'll look at it later.


Cheers!