Re: [bug #41246] Allow to switch shell batch mode at runtime instead of build time

[Mike Hommey]

On Thu, Feb 06, 2014 at 12:42:46PM +0200, Eli Zaretskii wrote:
> > Date: Thu, 6 Feb 2014 18:54:33 +0900
> > From: Mike Hommey <address@hidden>
> > Cc: address@hidden, address@hidden, address@hidden
> > 
> > The point is, batch shell mode only flag is advertized in config.h as
> > being the workaround for the broken sh -c. I'd like that workaround to
> > be available at runtime instead of build time.
> 
> I don't have a problem with that, never did.
> 
> > And now that i look at it, it *is* another sh -c bug. sigh.
> 
> MSYS Bash _is_ weird, it tries to solve a hard problem, and sometimes
> fails.  That's why using it with a native Make is not such a great
> idea.
> 
> > I'd be all for detecting if the shell used is win32 native or not
> 
> Make already does that, but only by the executable's file name.  I
> don't see any good reasons to try detecting MSYS Bash as opposed to
> native Windows ports of shells, as there aren't good native ports.
> 
> > at least, a user-runtime-togglable workaround for that would be better.
> > So we're back to square one. How about that first patch of mine?
> 
> I have no problems with your original patch.  I think I said that
> right there and then.  If Paul agrees, I will commit it.

Paul?