RE: [PATCH] Refactor and merge child_execute_job() code, new attempt

[Pavel Fedin]

 Hello!

> I like this patch; it looks like a good improvement!  It works fine for
> me on UNIX systems.
> 
> Only one comment:
> 
> > -      /* undo CLOSE_ON_EXEC() after the child process has been started
*/
> > +      /* undo FD_CLOEXEC after the child process has been started */
> 
> I think this change should be reverted, since we decided to keep the
> CLOSE_ON_EXEC() macro.

 Of course, i've just forgot about the comment. :)
 Ok, i'm waiting for the change to be committed in order to proceed with
Cygwin specifics.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia