[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/6] * expand.c (variable_name_extract): extract variable

From: Paul Smith
Subject: Re: [PATCH v2 1/6] * expand.c (variable_name_extract): extract variable name and strip prefix.
Date: Mon, 18 Aug 2014 10:35:19 -0400

On Mon, 2014-08-18 at 21:27 +0800, Macpaul Lin wrote:
> Variables used in conditional lines usually has '$',
> '(', and ')' prefix, and etc.
> We can use vairable_name_extract() to extract pure variable
> name without these prefix.

Hello.  Thanks for your work on GNU make!

Can you provide some sort of summary of the feature you've created, what
its goals are, examples, etc.?

It can be helpful to contact me or someone on the development team
before (or while) doing feature work for GNU make.  As a GNU project,
for example, we'll need to get copyright assignment paperwork for any
contribution of significant size and this takes some time.

Also, we may have suggestions or alternative implementations or concerns
that should be considered.  Of course these can always be addressed
later, but it can save some effort to think about them up-front.

And finally, note that fully-formed changes need to have at least a stab
at changes to the manual (I usually rework these but it's helpful to
have a starting point) and some additions to the regression test suite,
if possible.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]