Re: Strangeness in w32/subproc/sub_proc.c

[Eli Zaretskii]

> From: Gisle Vanem <address@hidden>
> Date: Thu, 5 Nov 2015 14:08:14 +0100
> 
> Some lines in this file seems a bit strange.
> Line 755:
> 
>   if (arr2envblk(envp, &envblk, &envsize_needed) == FALSE) {
>              pproc->last_err = 0;  << !!
>              pproc->lerrno = E_NO_MEM;
>              free( command_line );
>              if (pproc->last_err == ERROR_INVALID_PARAMETER
>                 && envsize_needed > 32*1024) {
> 
> With the above, the 'if (pproc->last_err ..' test will never
> be hit. So the "pproc->last_err = 0" should be put after
> the warning. Patch attached.

Thanks, pushed.

Btw, according to my counting, you've all but exhausted the number of
lines in patches we are allowed to accept without legal paperwork.
Would you like to start your paperwork now, so that your next
contribution is not rejected due to these reasons?  If so, I can send
you the copyright assignment form.

TIA