[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #45728] .VARIABLES not updated after undefine

From: Paul D. Smith
Subject: [bug #45728] .VARIABLES not updated after undefine
Date: Sun, 13 Mar 2016 22:29:17 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Update of bug #45728 (project make):

                  Status:                    None => Fixed                  
             Assigned to:                    None => psmith                 
             Open/Closed:                    Open => Closed                 
           Fixed Release:                    None => SCM                    
           Triage Status:                    None => Small Effort           


Follow-up Comment #2:

This was tricky.  GNU make tries to avoid the overhead of computing .VARIABLES
unless you need it, and also unless it changed from the last time it was
computed.  It used the number of variables in the hash table to determine
whether the value needed to be recomputed.  This was find when we weren't
removing entries on undefine, but when we started to do that now the value is
not reliable: if you remove one variable and add one variable (or any equal
number of adds and removes) in between expanding .VARIABLES then it doesn't
detect that there was a change and doesn't re-compute the .VARIABLES value.

I fixed this in Git by introducing a "change number" for variables which is
monotonically increasing, during both adds and removes.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]