[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unlink failure on abort

From: Paul Smith
Subject: Re: Unlink failure on abort
Date: Thu, 14 Dec 2017 08:30:05 -0500

On Sun, 2017-12-03 at 17:39 +0200, Orgad Shaneh wrote:
On Fri, Jun 23, 2017 at 2:59 AM, Paul Smith <address@hidden> wrote:
On Tue, 2017-06-20 at 18:20 +0300, Eli Zaretskii wrote:
Date: Sun, 18 Jun 2017 17:42:51 +0300 From: Eli Zaretskii <address@hidden> Cc: address@hidden, address@hidden
I think the problem is that reap_children() is called after delete_child_targets, so the child jobs can still run while make is trying to delete. Maybe delete_targets should become part of reap_children (it cannot be called after reap, because at this point you don't have the target info anymore). What do you say?
I will let Paul to chime in and comment about that. Failing that, I will push your changes after trying them on my box here.
Paul, could you please comment on Orgad's proposal above?
Conceptually I don't have any problems with the idea. I'd need to dig into the code more to be sure of any side-effects, and/or examine any posted solution carefully of course.

Seems OK to me.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]