[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #53879] Support for .ONESHELL target on Windows and DOS platforms

From: Paul D. Smith
Subject: [bug #53879] Support for .ONESHELL target on Windows and DOS platforms
Date: Sun, 5 Aug 2018 08:49:13 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Follow-up Comment #3, bug #53879 (project make):

Thanks for the patch it would be great to have this work on Windows.  I agree
with Eli that as it is the patch is large enough to require paperwork.  If
you're interested in that please send me email <address@hidden>.  These days
it can all be done electronically in most countries.

It seems one major source of work is a temp filename generator in
create_batch_file(); does MSDOS not have any pre-existing function?  Maybe
this could be simplified; I doubt we need a truly randomized file name
generator on DOS as it's not really a multiprocessing system so doesn't have
the same security issues.

In any event I'd prefer to see that system-specific code moved to a different
file but we can handle that ourselves if you prefer.

The thing I didn't quite understand was the variable.c change which removes a
bunch of code... that code is not moved anywhere that I can see so I'm not
sure whether it's just not needed at all, or what?  Maybe Eli can look at that
to better understand it.

There are a few nits such as adding a declaration of _is_dos_shell() to
makeint.h when that's actually just a preprocessor macro in job.c, etc. but
these are easy to fix.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]