[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spaw

From: Barath Aron
Subject: Re: [PATCH 2/2] job.c: implementing child_execute_job() using posix_spawn(), and use it if present
Date: Mon, 6 Aug 2018 11:05:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 08/05/2018 02:50 PM, Paul Smith wrote:

I pushed these changes to Git yesterday.  Please verify it works in
your environment.

Commit that I used: a1bb739165a944769cbb4a6e4f027ac9c2587122

Threos libc does not support the write of 'environ'. Thus, I had to add minor changes. Some part of it might can be pushed into the repository. See the attached patch file. Dispite this patch, it compiled successfully on Threos (using cross-compiler), and it works for my test cases (not the whole test suite due to different reasons).
Thank you very much for your effort to make it working!

This version also works on native Arch Linux, and "make check" succeeds.

I found a possible typo in NEWS:

diff --git a/NEWS b/NEWS
index 5395fc8..9808f90 100644
--- a/NEWS
+++ b/NEWS
@@ -46,10 +46,10 @@ http://sv.gnu.org/bugs/index.php?group=make&report_id=111&fix_release_id=108&set  * Makefiles can now specify the '-j' option in their MAKEFLAGS variable and
   this will cause make to enable that parallelism mode.

-* GNU make will now use pthread_spawn() on systems where it is available.
+* GNU make will now use posix_spawn() on systems where it is available.
   It will select POSIX_SPAWN_USEVFORK where that is available.  If you prefer    to use fork/exec even on systems where pthread_spawn() is present, you can
-  use the --disable-pthread-spawn option to configure.
+  use the --disable-posix-spawn option to configure.
   Aron Barath <address@hidden> provided the basic implementation.

 * Error messages printed when invoking non-existent commands have been cleaned

Attachment: job.c.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]