Re: __alloca patch?

[Jeffrey Walton]

On Sat, May 4, 2019 at 4:34 PM Jeffrey Walton <address@hidden> wrote:
>
> On Sat, May 4, 2019 at 3:14 PM Paul Smith <address@hidden> wrote:
> >
> > On Sat, 2019-05-04 at 15:10 -0400, Jeffrey Walton wrote:
> > > Ack, thanks. It works perfectly on Fedora 29.
> > >
> > > This was a good change:
> > >
> > > -# if _GNU_GLOB_INTERFACE_VERSION == GLOB_INTERFACE_VERSION
> > > +# if _GNU_GLOB_INTERFACE_VERSION == 1 || _GNU_GLOB_INTERFACE_VERSION == 2
> > >
> > > I found the one discussed on the mailing list and used it. But it
> > > looks like it was wrong:
> > >
> > > # if _GNU_GLOB_INTERFACE_VERSION >= GLOB_INTERFACE_VERSION
> >
> > Well, they're equivalent at the moment, but who knows what the future
> > may bring? :)
> >
> > These changes were all cherry-picked from commits already present in
> > the latest Git HEAD.  See the Git commit history for attribution.
>
> It tested OK on Solaris 11.3 also.
>
> I had to sidestep an autoreconf because Solaris provides an old
> version of Autotools. See
> https://github.com/noloader/Build-Scripts/commit/d831d99544be .

And tested OK on OS X 10.9 x86_64. This build was a tad bit noisy, but
tested OK.

gcc -DHAVE_CONFIG_H -I. -I..   -I/usr/local/include -DNDEBUG  -g2 -O2
-march=native -fPIC -pthread -MT fnmatch.o -MD -MP -MF
.deps/fnmatch.Tpo -c -o fnmatch.o fnmatch.c
glob.c:818:27: warning: incompatible pointer types passing 'char **' to
      parameter of type 'char *'; dereference with *
      [-Wincompatible-pointer-types]
            = (char **) realloc (pglob->gl_pathv,
                                 ^~~~~~~~~~~~~~~
                                 *
glob.c:937:24: warning: incompatible pointer types passing 'char **' to
      parameter of type 'char *'; dereference with *
      [-Wincompatible-pointer-types]
                = (char **) realloc (pglob->gl_pathv,
                                     ^~~~~~~~~~~~~~~
                                     *
...

Jeff