GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

[Dennis Clarke]

On 8/26/19 9:00 AM, Paul Smith wrote:
>      --------------------------------------------------------------------
>      GNU make is a tool which controls the generation of executables and
>      other non-source files of a program from the program's source files.
>
>      You can learn more at: https://www.gnu.org/software/make/
>      --------------------------------------------------------------------
>
> A new release candidate for GNU make 4.3 is available now for download:
>
>      36083ab822b50a9ecbf5467cdadff55c  make-4.2.90.tar.bz2
>      e2c9abdeaf3725f8654a5e9d7a121fa9  make-4.2.90.tar.gz
>
> You can obtain a copy from:  https://alpha.gnu.org/gnu/make/
>
> - NEWS ----------------------------------------------------------------
>
> Version 4.2.90 (26 Aug 2019)
>
> A complete list of bugs fixed in this version is available here:

Testing on a few system and seems to fail the testsuite in various ways
on multiple systems. Does not compile on FreeBSD 12.0-RELEASE-p10 amd64
with LLVM/Clang thus :

vesta$ $CC --version
FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on 
LLVM 6.0.1)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin
vesta$

vesta$ echo $CFLAGS
-m64 -std=c99 -O0 -g -Werror -no-integrated-as -fno-fast-math 
-fno-builtin -fdiagnostics-format=vi -fno-color-diagnostics
vesta$

Saw this :



/usr/bin/cc -DHAVE_CONFIG_H -I. -I../src   -D_TS_ERRNO 
-D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE  -m64 -std=c99 -O0 -g 
-Werror -no-integrated-as -fno-fast-math -fno-builtin 
-fdiagnostics-format=vi -fno-color-diagnostics -MT glob.o -MD -MP -MF 
.deps/glob.Tpo -c -o glob.o glob.c
glob.c +823:27: error: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * 
[-Werror,-Wincompatible-pointer-types]
            = (char **) realloc (pglob->gl_pathv,
                                 ^~~~~~~~~~~~~~~
                                 *
glob.c +942:24: error: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * 
[-Werror,-Wincompatible-pointer-types]
                = (char **) realloc (pglob->gl_pathv,
                                     ^~~~~~~~~~~~~~~
                                     *
glob.c +997:39: error: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * 
[-Werror,-Wincompatible-pointer-types]
              new_pathv = (char **) realloc (pglob->gl_pathv,
                                             ^~~~~~~~~~~~~~~
                                             *
glob.c +1388:23: error: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * 
[-Werror,-Wincompatible-pointer-types]
        = (char **) realloc (pglob->gl_pathv,
                             ^~~~~~~~~~~~~~~
                             *
4 errors generated.
gmake[3]: *** [Makefile:888: glob.o] Error 1
gmake[3]: Leaving directory 
'/opt/bw/build/make-4.2.90_FreeBSD_12.0-p10_amd64.001/lib'
gmake[2]: *** [Makefile:908: all-recursive] Error 1
gmake[2]: Leaving directory 
'/opt/bw/build/make-4.2.90_FreeBSD_12.0-p10_amd64.001/lib'
gmake[1]: *** [Makefile:814: all] Error 2
gmake[1]: Leaving directory 
'/opt/bw/build/make-4.2.90_FreeBSD_12.0-p10_amd64.001/lib'
gmake: *** [Makefile:1293: all-recursive] Error 1
vesta$

So that should be just a mismatch on the types.
I have already patched that here locally.


Also :


/usr/bin/cc -DHAVE_CONFIG_H   -Isrc -I./src -Ilib -I./lib 
-DLIBDIR=\"/opt/bw/lib\" -DINCLUDEDIR=\"/opt/bw/include\" 
-DLOCALEDIR=\"/opt/bw/share/locale\"  -D_TS_ERRNO 
-D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE  -m64 -std=c99 -O0 -g 
-Werror -no-integrated-as -fno-fast-math -fno-builtin 
-fdiagnostics-format=vi -fno-color-diagnostics -MT src/getopt.o -MD -MP 
-MF $depbase.Tpo -c -o src/getopt.o src/getopt.c &&\
mv -f $depbase.Tpo $depbase.Po
src/getopt.c +685:6: error: add explicit braces to avoid dangling else 
[-Werror,-Wdangling-else]
                   else
                   ^
1 error generated.
gmake[1]: *** [Makefile:1207: src/getopt.o] Error 1
gmake[1]: Leaving directory 
'/opt/bw/build/make-4.2.90_FreeBSD_12.0-p10_amd64.001'
gmake: *** [Makefile:1293: all-recursive] Error 1

That seems a bit pedantic.

I am walking through the function _getopt_internal and doing some code
cleanup.

I also have 32-bit Debian on arm and FreeBSD on ppc64 and Solaris on
Fujitsu SPARC and other systems.  They all fail the testsuite in various
ways.  For now.



--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional