bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch locale settings


From: Paul Smith
Subject: Re: patch locale settings
Date: Sat, 14 Sep 2019 10:21:49 -0400
User-agent: Evolution 3.32.1-2

On Fri, 2019-09-13 at 21:43 -0400, Dmitry Goncharov via Bug reports and
discussion for GNU make wrote:
> Multiple tests fail when locale related env variables (such as LANG or
> LC_MESSAGES) are set to some regional setting.

This should not be necessary because we already do this, in
test_driver.pl:

  # Make sure our compares are not foiled by locale differences

  $makeENV{LC_ALL} = 'C';

and, I've checked with a makefile invoked by the test suite and this
setting is in effect, even if the shell invoking run_make_tests.pl has
a different setting for LC_ALL.

Furthermore, we clear out the environment so that only a set number of
variables are actually reserved, and LANG is not one of them (nor is
LC_MESSAGES), so setting LANG in the run_make_tests shell script should
not have any effect.

I need to understand your failure situation better before applying this
change.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]