[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gmake-4.2.90 regression (segmentation fault in sum_up_to_nul )
|
From: |
Dmitry Goncharov |
|
Subject: |
Re: gmake-4.2.90 regression (segmentation fault in sum_up_to_nul ) |
|
Date: |
Wed, 25 Sep 2019 17:23:50 -0400 |
On Tue, Sep 24, 2019 at 1:01 PM Paul Smith <address@hidden> wrote:
> The reason for the "special" code here is
> performance, and unfortunately the solution proposed will reduce
> performance by a measurable amount (not huge but measurable).
Paul, is this call to strlen that you are concerned with?
It is possible to optimize somewhat (at the expense of source code
simplicity) by having jhash_string take the length of the string from
the caller.
Atleast some of the callers (e.g. file.c) already call strlen.
Or are you concerned with the computation to update klen?
regards, Dmitry