[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #57242] Non-recursive command passes invalid jobserver file descrip

From: Stefan Brüns
Subject: [bug #57242] Non-recursive command passes invalid jobserver file descriptors
Date: Tue, 19 Nov 2019 17:24:28 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Follow-up Comment #2, bug #57242 (project make):

[comment #1 comment #1:]
> Stefan, the behavior you described is intended.
> make closes the pipe unless the command has + or (MAKE) or {MAKE}.
> This is necessary, because a command can mess up job server operation or a
command may expect a specific fd to be available.

Then at least the information should be consistent and the MAKEFLAGS should
not mention jobserver FDs.

As is, it already messes up make itself - a make process invocated indirectly
may get valid filedescriptors *not* belonging to the jobserver, and start busy
looping on the "read(rfd, 1)" call (when the other end is closed and read
returns 0).


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]