[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] [SV 54161] Fix second expansion of $*

From: Paul Smith
Subject: Re: [PATCH v2 2/3] [SV 54161] Fix second expansion of $*
Date: Wed, 18 Dec 2019 09:11:21 -0500
User-agent: Evolution 3.34.1-2

On Sat, 2019-11-23 at 12:22 +0100, Jouke Witteveen wrote:
> Is there anything I can do to further review and/or acceptance of this
> patch I sent last month?

I applied your changes although updates were needed.

For the future, please note that (a) changes should contain updates to the
regression tests to show the error and ensure the fix works, (b) commit
messages need to be formatted properly so that they can be generated into
ChangeLog entries, (c) we cannot use GNU libc-only functions like memrchr()
since GNU make is highly portable and runs on Windows, VMS, etc., not to
mention BSD, MacOS, and other POSIX systems where glibc is not available.

I added a regression test based on the Savannah bug report, reformatted the
commit messages, and added an implementation of memrchr() for systems where
it doesn't exist.

Thanks for the fix!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]