bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #59956] Recipes inside conditionals can break the parser


From: Paul D. Smith
Subject: [bug #59956] Recipes inside conditionals can break the parser
Date: Thu, 28 Jan 2021 12:23:52 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36

Follow-up Comment #10, bug #59956 (project make):

Using *otherwise* means that now if a recipe runs a program named *otherwise*,
it will start to fail whereas before it succeeded.

I'm really not jazzed about creating new esoteric syntax for this problem. 
Anyway, adding new syntax doesn't really help IMO.  There are already ways to
work around this problem by modifying the makefile: we don't need to create
anything new for that.  The hope is to find a way to make the current syntax
work "as expected", at least in the large majority of cases, without requiring
people to rewrite makefiles.

> Being able to indent the conditionals would be a big plus.

You CAN indent conditionals.  You just CAN'T indent them with the
*.RECIPEPREFIX* (TAB by default).

My feeling is that this is entirely reasonable.  Any attempt to allow TAB for
generic indentation by making a distinction between a recipe context and not a
recipe context is doomed to failure and future pain, and this has been true
ever since *ifeq* was invented.

If you really need to use TAB for indentation then you should modify your
makefiles to use a different *.RECIPEPREFIX* value.  Anything else is madness,
or at least leads that way.

Anyway that's my $0.02.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59956>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]