[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #61042] Enhance implicit rule search logging

From: Paul D. Smith
Subject: [bug #61042] Enhance implicit rule search logging
Date: Sun, 17 Oct 2021 11:18:29 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36

Follow-up Comment #4, bug #61042 (project make):

Dmitry I'm not sure about this change:

@@ -744,15 +752,9 @@ pattern_search (struct file *file, int archive,
                   /* If this prereq is also explicitly mentioned for FILE,
                      skip all tests below since it must be built no matter
                      which implicit rule we choose. */
                   for (expl_d = file->deps; expl_d != 0; expl_d =
                     if (streq (dep_name (expl_d), d->name))
-                  if (expl_d != 0)
-                    {
-                      (pat++)->name = d->name;
-                      continue;
-                    }
                   /* The DEP->changed flag says that this dependency resides
                      in a nonexistent directory.  So we normally can skip

Why are we removing this shortcut here?  It seems like we're paying a cost
everywhere to get better output when debugging is enabled...?  Or is there
some correctness reason to remove this?


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]