[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix type errors in win32.
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Fix type errors in win32. |
Date: |
Mon, 29 Nov 2021 05:24:57 +0200 |
> From: Paul Smith <psmith@gnu.org>
> Cc: bug-make@gnu.org
> Date: Sun, 28 Nov 2021 15:19:15 -0500
>
> On Mon, 2021-10-25 at 15:32 +0300, Eli Zaretskii wrote:
> > the default C runtime used by Make doesn't support %llu, at least not
> > on Windows versions older than Windows 10.
>
> Hrm, I just added a new use of sprintf() with %lld into GNU make, to
> format a long long variable. It worked for me in my trivial Windows
> tests but I am using Windows 10 with MSVC 2019 so pretty new. I don't
> have the facilities to test older systems.
If you used MSVC 2019, you are not using the default MSVCRT.DLL
runtime.
> Should I be using %I64d instead on Windows, to allow support for older
> systems?
Yes, IMO. You can also use PRIdMAX from inttypes.h for portability.