[bug #48643] Irrelevant targets can confuse make on which pattern rule to select.

[Dmitry Goncharov]

Follow-up Comment #31, bug #48643 (project make):

Paul, in update 27 i added 2 patches. sv48643_exp_preqreq_is_not_interm.diff
has a fix for example 6. sv48643_exp_preqreq_is_not_interm_tests.diff has
related tests.

Not sure, if you decided not to apply these 2 patches or they fell through the
cracks.

You introduced another change in commit 6682fb. This change in commit 6682fb
causes example 6 to succeed even when sv48643_exp_preqreq_is_not_interm.diff
is not applied.

However, without sv48643_exp_preqreq_is_not_interm.diff
pat->is_explicit has incorrect value of 0 in cases like example 6. This
incorrect value of pat->is_explicit now goes unnoticed with this new
assigment
f->is_explicit |= imf->is_explicit || pat->is_explicit;
, because f->is_explicit is set in enter_prereqs.

My concern is that this incorrect value of pat->is_explicit can manifest
itself in some other scenario or after a change is introduced. For example,
this incorrect value is assigned to
dep->is_explicit = pat->is_explicit;
a few lines below.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?48643>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/