Re: oddball messages on FreeBSD that cause make to fail the testsuite

[Paul Smith]

On Mon, 2022-02-14 at 18:54 -0500, Dennis Clarke wrote:
> variable 'plugin_is_GPL_compatible' [-Wmissing-variable-declarations]

This is happening because you're adding extra compile-time options to
the standard GNU make build, and those options are getting passed
through to the test suite.

Most likely we should expend a little effort to sanitize the options
provided to the compiler in the test suite to remove unneeded things
like extra warnings.

However, in general when compiling external tools it's probably not a
good idea to force extra warning flags etc. into the build, unless
you're actually trying to develop or debug the code.  If you're just
trying to build it to use it, then adding extended warnings usually
just generates spurious issues.