[bug #57242] Non-recursive command passes invalid jobserver file descriptors

[Paul D. Smith]

Follow-up Comment #13, bug #57242 (project make):

OK; I guess if it's the old style anonymous pipe you do something different?

One note: an ideal implementation would look for the _last_ instance of
--jobserver-auth in MAKEFLAGS, not the first instance.  In the current code in
Git, if we are using anonymous pipes and we invoke a sub-process which is not
considered to be a recursive make, we will add an extra
"--jobserver-auth=-2,-2" to the END of MAKEFLAGS to disable the jobserver
(unfortunately it's complicated to try to replace the existing option so
instead we just add an overriding option.

This should make the jobserver more reliable than before, even when using
anonymous pipes.  It doesn't solve all problems though: named pipes works
better in many situations.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57242>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/