[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] shuffle: disable by default

From: Paul Smith
Subject: Re: [PATCH] shuffle: disable by default
Date: Sun, 16 Oct 2022 08:39:16 -0400
User-agent: Evolution 3.46.0 (by Flathub.org))

On Sun, 2022-10-16 at 12:17 +0200, Yann E. MORIN wrote:
> Commit 621d3196fae9 ([SV 62100] Add '--shuffle' option support)
> introduced randomisation of prerequisites, so as to detect more
> build ordering issues, especially with parallel builds. It also
> made randomisation the default.

I'm not sure I understand the goal of this patch.

If you don't want randomization, just don't add the --shuffle option
and you won't get any randomization.

The behavior of make without the --shuffle option hasn't changed from
what it was before: it will never be the case that shuffle is the
default "always on" behavior because POSIX mandates the order in which
prerequisites are considered.

So I don't see why we would say that both "make" and "make --shuffle"
do the same thing (no shuffle).  If you've added --shuffle then I'd
expect you'd want to see shuffling...?

Am I wrong and there is some way to get shuffle mode enabled even
without the --shuffle option?  That would definitely be a bug!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]