[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Fix duplicated __strchrnul() declaration error on OS/2 k

From: Paul Smith
Subject: Re: [PATCH 1/2] Fix duplicated __strchrnul() declaration error on OS/2 kLIBC
Date: Sun, 13 Nov 2022 17:34:51 -0500
User-agent: Evolution 3.46.1 (by Flathub.org)

On Wed, 2022-11-09 at 22:45 +0900, KO Myung-Hun wrote:
> OS/2 kLIBC has __strchrnul(). But HAVE___STRCHRNUL is undefined.
> 'static' declarion of __strchrnul() causes an error with gcc4 because
> OS/2 kLIBC declares __strchrnul() as public.

I assume kLIBC is a libc implementation for OS/2?

I'm not sure I like this solution, mainly because fnmatch.c and glob.c
are "inherited" from gnulib and I don't like to change them (although
they are very far divorced from upstream at this point).

My understanding of the problem is that we are missing a
HAVE__STRCHRNUL.  Wouldn't it make more sense to add that to the

But, I don't quite understand how the configure works on OS/2.  Can you
clarify whether the steps in the README.OS2 document are still correct?
Do you indeed run the configure script etc. and is there enough support
on OS/2 for that to work?

Maybe the first thing that needs to be done is to review the contents
of the README.OS2 and verify that it still is all valid, and if not
submit changes to make it correct.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]