bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #63516] `include` of absolute path prepends path with `./`


From: anonymous
Subject: [bug #63516] `include` of absolute path prepends path with `./`
Date: Fri, 16 Dec 2022 08:38:53 -0500 (EST)

Follow-up Comment #6, bug #63516 (project make):


[comment #5 comment #5:]
> Thanks for the patch.
> 
> I have three comments:
> 
> (1) The test under "WINDOWS32" should allow a backslash after the colon as
well as a forward slash.

Sounds right.

> 
> (2) Do we want Make to consider "drive-relative" file names, as in
"d:foo/bar", relative or absolute?  I think the latter, so I suggest not to
require the 3rd character to be a slash, in which case (1) gets solved
automatically.

`d:foo/bar` is wierd; it's relative if your current drive is `d:`, otherwise
it's absolute.

> 
> (3) Unis-style absolute file names, like "/foo/bar", should also be
considered "absolute" on Windows, and likewise "\foo\bar".  Which brings the
backslash issue back.

You're right.  I had just made a quick change to keep me going.  The proper
changes will be somewhat more complicated.  If I get the chance to provide a
proper fix before I see a patch in the repo, I'll post a better fix here.

On the `bootstrap.bat` change: I don't know if that is peculiar to my setup;
I'm running from powershell.  I don't think that that would make a difference
to the interpretation of `.bat` files, but windows quoting is weird, so who
knows.

Thanks for the feedback.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63516>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]