[bug #31248] .SECONDEXPANSION: Inconsistent expansion of glob patterns in pattern rule dependency lines

[Paul D. Smith]

Follow-up Comment #1, bug #31248 (project make):

I've tested this with the latest GNU Make 4.4(.1).  I didn't really follow all
the discussion of previous behaviors, but here is how things currently behave,
which doesn't seem right to me:

Given the setup below, when run without second expansion:

$ make SEC=no
dir/foo.x from dir/foo.ybot

we can see that the directory prefix "dir/" is added to the pattern "%y*"
_before_ the glob is expanded, so that the expansion finds the pre-existing
dir/foo.ybot.

However if we enable second expansion:

$ make SEC=yes
dir/foo.ytop
dir/foo.x from dir/foo.ytop

we can see that here, the pattern is replaced giving "foo.y*" and the glob is
expanded before the directory prefix "dir/" is added, yielding foo.ytop which
is then changed to "dir/foo.ytop".

Clearly the fact that these work differently is wrong.

As for which should happen, my preference would probably be to change the
second expansion one to work like the no-second-expansion one, where first the
directory prefix is handled then the glob expansion is done afterward.  Adding
the directory prefix is part of expanding the pattern, and expanding the
pattern should happen before the glob match.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?31248>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/