Re: Regression on Cygwin: Problems with parallel make in 4.4

[Paul Smith]

On Tue, 2023-02-21 at 10:36 -0500, Paul Smith wrote:
> But, I think I might have found the bug.  If I'm right, it's a doozy!
> But, as you mentioned it's not widespread because it only affects
> pipe jobservers.  I'm glad 4.4.1 is almost ready to go.  I'll try to
> write a test case for it to see if I'm right.

I was able to write a regression test that shows the bug.

Can you please apply the change below and see if it fixes the problem?
I don't think this is the final solution I'll apply for 4.4.1 but it
will let me know if I'm on the right track.


diff --git a/src/job.c b/src/job.c
index 94df0197..d054ae1b 100644
--- a/src/job.c
+++ b/src/job.c
@@ -1422,7 +1422,8 @@ start_job_command (struct child *child)
 #ifndef _AMIGA
   /* Set up the environment for the child.  */
   if (child->environment == 0)
-    child->environment = target_environment (child->file, child->recursive);
+    child->environment = target_environment (child->file,
+                                             child->file->cmds->any_recurse);
 #endif

 #if !defined(__MSDOS__) && !defined(_AMIGA) && !defined(WINDOWS32)