[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use UTF-8 active code page for Windows host.

From: Paul Smith
Subject: Re: [PATCH] Use UTF-8 active code page for Windows host.
Date: Sat, 08 Apr 2023 00:32:05 -0400
User-agent: Evolution 3.48.0 (by Flathub.org)

On Fri, 2023-04-07 at 08:29 -0400, Paul Smith wrote:
> > Also, I'm still waiting for Paul to approve the changes to Posix
> > configury part of your patch.
> Sorry I will make every effort to get to it today.

The configure part looks OK to me.  This change to Makefile.am seems
not quite correct to me however:

@@ -90,6 +92,14 @@ else
   make_SOURCES += src/posixos.c
+  UTF8OBJ     = src/w32/utf8.$(OBJEXT)
+  make_LDADD += $(UTF8OBJ)
+$(UTF8OBJ) : $(w32_utf8_SRCS)
+       $(WINDRES) $< -o $@
   make_SOURCES += src/remote-cstms.c

Here if HAVE_WINDRES is not set, then UTF8OBJ is empty, and you create
a recipe with an empty target.  Now, this works in GNU Make (and is
ignored) but some other versions of make may not like it.

I think you should move the assignment of UTF8OBJ out of the if-
statement here, and only put the update of make_LDADD into the if-
statement.  That should be sufficient to have make ignore that target,
if there's no WINDRES available.

After that if Eli is happy with it he can push it to Git.

I will say that I think this is at the very edge of what we can accept
without copyright assignment.  If this change gets larger, or if you
want to contribute more in the future, we'll need to have paperwork.

Thanks for your contribution to GNU Make!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]