bug-mes
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH master] Prepare header files for ARMv4.


From: Jan Nieuwenhuizen
Subject: Re: [PATCH master] Prepare header files for ARMv4.
Date: Tue, 02 Jun 2020 10:05:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Danny Milosavljevic writes:

>  #define      O_WRONLY          2
> diff --git a/include/signal.h b/include/signal.h
> index 877b2d55..d8152f34 100644
> --- a/include/signal.h
> +++ b/include/signal.h
> @@ -126,6 +126,7 @@ typedef long sighandler_t;
>  typedef void (*sighandler_t) (int);
>  #endif
>  
> +#if __i386__ || __x86_64__

Just to give you a headsup of what's coming...I'll be resuming work
towards the full source bootstrap the coming year; which means making
all of mes and mes lib c compilable by m2-planet; i.e.: no preprocessor,
so no macros, no includes.

Of course, we will still keep mes buildable with gcc too...So, some of
this may have to change later and I apologise in advance; for now it's
all great!

>  struct sigaction
>  {
>    union
> @@ -144,7 +145,18 @@ struct sigaction
>    //unsigned long sa_flags; // x86?
>    void (*sa_restorer) (void);
>  };
> -
> +#else /* uapi */
> +struct sigaction {

Brace on next line, please:

struct sigaction
{

(sorry to be so nit-picky!)

LGTM!

Janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | AvatarĀ® http://AvatarAcademy.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]