[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] guix: mes: Add armhf-linux, aarch64-linux support.
|
From: |
Danny Milosavljevic |
|
Subject: |
Re: [PATCH] guix: mes: Add armhf-linux, aarch64-linux support. |
|
Date: |
Thu, 4 Jun 2020 21:55:31 +0200 |
Hi Janneke,
On Thu, 04 Jun 2020 21:46:22 +0200
Jan Nieuwenhuizen <janneke@gnu.org> wrote:
> Danny Milosavljevic writes:
>
> > Same patch with ignore-whitespace, for easier review:
> > diff --git a/guix/git/mes.scm b/guix/git/mes.scm
> > index 78ae32b6..304257ce 100644
> > --- a/guix/git/mes.scm
> > +++ b/guix/git/mes.scm
>
> [..]
>
> > - (supported-systems '("i686-linux" "x86_64-linux"))
> > + (supported-systems '("aarch64-linux" "armhf-linux" "i686-linux"
> > "x86_64-linux"))
> > (propagated-inputs
>
> Nice...I'm wondering now though; shouldn't you been LGTM'ing this?
Yeah, I guess :)
It has been quite some time since you wrote that patch and I didn't want to
push it without review--there could have been a reason it's not on master.
LGTM!
Pushed to mes master as commit a44544bae98fd9711f9bf2f784b2d727e3db528f.
pgpx6emjtJonC.pgp
Description: OpenPGP digital signature