Re: [PATCH] libc-mini: Don't print newline in puts

[W. J. van der Laan]

Oh you're right, it should write a trailing newline. Strange, I never noticed 
this before.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Sunday, April 18th, 2021 at 5:21 PM, Jan Nieuwenhuizen <janneke@gnu.org> 
wrote:

> W. J. van der Laan writes:
>
> Hello,
>
> > -   lib/stdlib/puts.c (puts): Don't print a newline after printing the
> >
> >     string, as this is not part of the specified behavior.
>
> Thanks for the patch, it looks nice. However, the GNU libc manual says
>
> https://www.gnu.org/software/libc/manual/html_node/Simple-Output.html#index-puts
>
> --8<---------------cut here---------------start------------->8---
>
> Function: int puts (const char *s)
>
> The puts function writes the string s to the stream stdout followed by
>
> a newline. The terminating null character of the string is not
>
> written.
>
> --8<---------------cut here---------------end--------------->8---
>
> Maybe what you see is that we don't really have FILE* in the Mes C
>
> library, fputs should not print a newline?
>
> It would be great to remove the FILE* => fd hack and introduce a FILE
>
> struct...
>
> Greetings,
>
> Janneke
>
> -------------------------------
>
> Jan Nieuwenhuizen janneke@gnu.org | GNU LilyPond http://lilypond.org
>
> Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com