Re: Support for uppercase hex conversions

[Janneke Nieuwenhuizen]

R. Masters writes:

Hi Rick,

> Uppercase hex number conversions fail for abtol, strtol, strtoul,
> strtoull, atoi, and abtod.
>
> The following patch fixes it. This fix allows tcc to handle assembly
> language, which is necessary to build the Fiwix kernel as part of the
> kernel bootstrapping in progress for the live-bootstrap project.

Thanks for your bug report and for the fix!  I've updated your
copyright, added a GNU style ChangeLog to the commit message (see
range-diff below) and installed your patch on master as
b28f42de072d69b70e03c5d9b953689fd2a3586b.

Greetings,
Janneke

$ git range-diff HEAD~..HEAD b28f42de~..b28f42de
1:  6742207a ! 1:  b28f42de Support for uppercase hex conversions
    @@ Metadata
     Author: R. Masters <grick23@gmail.com>
     
      ## Commit message ##
    -    Support for uppercase hex conversions
    +    lib: Support uppercase hex conversions.
     
    -    Uppercase hex number conversions fail for abtol, strtol, strtoul, 
strtoull,
    -    atoi, and abtod.
    +    Uppercase hex number conversions fail for abtol, strtol, strtoul,
    +    strtoull, atoi, and abtod.
     
    -    The following patch fixes it. This fix allows tcc to handle assembly
    +    The following patch fixes it.  This allows tcc to handle assembly
         language, which is necessary to build the Fiwix kernel as part of the
         kernel bootstrapping in progress for the live-bootstrap project.
     
    +    * lib/ctype/isxdigit.c (isxdigit): Also allow A-F.
    +    * lib/mes/abtol.c (abtol): Also cater for A-F.
    +
    + ## lib/ctype/isdigit.c ##
    +@@
    + /* -*-comment-start: "//";comment-end:""-*-
    +  * GNU Mes --- Maxwell Equations of Software
    +  * Copyright © 2016,2017,2018 Jan (janneke) Nieuwenhuizen 
<janneke@gnu.org>
    ++ * Copyright © 2023 Rick Masters <grick23@gmail.com>
    +  *
    +  * This file is part of GNU Mes.
    +  *
    +
      ## lib/ctype/isxdigit.c ##
     @@
      int
    @@ lib/ctype/isxdigit.c
      }
     
      ## lib/mes/abtol.c ##
    +@@
    + /* -*-comment-start: "//";comment-end:""-*-
    +  * GNU Mes --- Maxwell Equations of Software
    +  * Copyright © 2016,2017,2018,2019,2020 Jan (janneke) Nieuwenhuizen 
<janneke@gnu.org>
    +- * Copyright © 2022 Rick Masters <grick23@gmail.com>
    ++ * Copyright © 2022,2023 Rick Masters <grick23@gmail.com>
    +  *
    +  * This file is part of GNU Mes.
    +  *
     @@ lib/mes/abtol.c: abtol (char const **p, int base)
        while (isnumber (s[0], base) != 0)
          {

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com