bug-mes
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] m2: fix build with new M2-Planet.


From: Janneke Nieuwenhuizen
Subject: Re: [PATCH] m2: fix build with new M2-Planet.
Date: Wed, 15 Feb 2023 10:26:03 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Andrius tikonas writes:

Hi Andrius,

> Newer M2-Planet is slightly more standards compliant and
> notices that we are assigning 64-bit struct (on x86) to function argument
> that is 32-bit wide.

Thanks for your report.  While this

> diff --git a/lib/m2/time.c b/lib/m2/time.c
> index c589de85..a052be7b 100644
> --- a/lib/m2/time.c
> +++ b/lib/m2/time.c
> @@ -26,8 +26,8 @@ long
>  time (long* result)
>  {
>    int r;
> -  struct timeval tv;
> -  struct timezone tz;
> +  struct timeval* tv;
> +  struct timezone* tz;
>    r = _sys_call2 (SYS_gettimeofday, tv, tz);
>    if (r != 0)
>      return -1;

seems to work, I'm afraid the structs are still not allocated?  I have
installed this fix instead:

    
https://git.savannah.gnu.org/cgit/mes.git/commit/?id=1e14c263050ead4bc43871183dc3139e162f35f0

see

    https://lists.gnu.org/archive/html/bug-mes/2023-01/msg00001.html

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]