Re: Impossibility of modifiable invisible fields

[Leon Winter]

Hi Thomas,

> Actually the manual page is vague.  It says:
> ...

I think "vague" is a very nice way to put it ;)

> I think the best approach is to first clarify in the documentation
> what the library actually does (and add test-cases which use both
> features):
> 
> a) O_SELECTABLE is an example from the test-program demo_forms.c
>    (not actually part of the library), but as noted, it combines
>    O_ACTIVE and O_VISIBLE.

It is part of the library and heavily used (internally):

$ grep -r O_SELECTABLE *
form.priv.h:#define O_SELECTABLE (O_ACTIVE | O_VISIBLE)
form.priv.h:#define Field_Is_Selectable(f)     (((unsigned)((f)->opts) & 
O_SELECTABLE)==O_SELECTABLE)
form.priv.h:#define Field_Is_Not_Selectable(f) (((unsigned)((f)->opts) & 
O_SELECTABLE)!=O_SELECTABLE)
$ grep -E 'Field_Is_Selectable|Field_Is_Not_Selectable' *
fld_current.c:  else if ((form != field->form) || 
Field_Is_Not_Selectable(field))
form.priv.h:#define Field_Is_Selectable(f)     (((unsigned)((f)->opts) & 
O_SELECTABLE)==O_SELECTABLE)
form.priv.h:#define Field_Is_Not_Selectable(f) (((unsigned)((f)->opts) & 
O_SELECTABLE)!=O_SELECTABLE)
frm_driver.c:      if (Field_Is_Selectable(*field_on_page))
frm_driver.c:      if (Field_Is_Not_Selectable(proposed))
frm_driver.c:      if (Field_Is_Selectable(*field_on_page))
frm_driver.c:      if (Field_Is_Selectable(field_on_page))
frm_driver.c:      if (Field_Is_Selectable(field_on_page))
frm_driver.c:                     if (Field_Is_Selectable(field)
frm_driver.c:                     if (Field_Is_Selectable(field)

> b) O_PUBLIC isn't tested or demonstrated.
> 
> With those documented, we can discuss changes starting from that.

Right. Once I take up the quest to implement the new feature I will need to
start looking into existing functional in detail anyway, so the insights and
documentation changes should result easily. Then I might be able to come up
with a plan where the modification/new feature would best fit in.

Regards,
Leon