Re: linker flags leaked into "ncurses*-config --libs"

[Thomas Dickey]

On Sat, Oct 12, 2019 at 11:01:14PM +0200, Sven Joachim wrote:
> On 2019-10-12 16:07 -0400, Thomas Dickey wrote:
> 
> > On Sat, Oct 12, 2019 at 09:22:14PM +0200, Sven Joachim wrote:
> >> There is a problem with the ncurses*-config script, LDFLAGS from the way
> >> the library is built are echoed in the "--libs" option:
> >>
> >> ,----
> >> | $ debian/libncurses-dev/usr/bin/ncurses6-config --libs
> >> | -Wl,-z,relro -Wl,-z,now -lncurses -ltinfo
> >
> > hmm - that was intentional (whether it was a Good Thing, we can discuss).
> 
> We had this discussion before for the pkg-config files[1], and at that
> time you filtered these flags out (thank you for doing that).

20150516
        + amend change to ".pc" files to only use the extra loader flags which
          may have rpath options (report by Sven Joachim, cf: 20150502).

> I want these to be filtered out before I make an upload to Debian, which
> will probably be relatively soon given the crash reports.  But I can
> certainly wait a week or look how to filter these flags out myself.

I can do this today.
 
> Okay, but none of these contains "-Wl,-z,relro" which is what
> dpkg-buildflags emits (the additional "-Wl,-z,now" comes from the
> bindnow hardening option applied in ncurses' debian/rules).

For the moment, filtering all of the "-Wl,-z" seems to address the problem.

-- 
Thomas E. Dickey <address@hidden>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature