Re: PSPAPI is currently unconditionally included if build on MSYS

[Thomas Dickey]

On Mon, Nov 11, 2019 at 01:35:03PM +0100, Simon Sobisch wrote:
>   Currently every build on MSYS (no matter if MinGW-GCC, VC or any other
>   compiler is used) unconditionally adds -lpspapi to LIBS.
>
>   The  following  patch  adds  a note *why* this is done and also a TODO
>   marker  as  configure should only do so if the library actually can be
>   linked  (maybe  output  a  warning if it cannot). _Maybe_ this library
>   isn't  necessary  at  all to build win_driver.c (which I _assume_ this
>   library is linked in) which likely can be verified with AC_CHECK_LIBS.
>
>   Ideally  the  additional  library  is  only  added  for  linking where
>   necessary (some   build  systems  will  complain  about  unneccessary
>   libraries).
>
>   As  a  temporary  work-around  to be able to complile with the OrangeC
>   compiler  on  MSYS  (only providing the additional used tools, not for
>   providing  the  compiler/linker) I've removed the additional link from
>   the configure script.
>
>   Simon

actually - see

https://docs.microsoft.com/en-us/windows/win32/api/psapi/nf-psapi-getprocessimagefilenamea

the library isn't needed.  I didn't notice this when Juergen made the
change, but the psapi.dll is only used when PSAPI_VERSION is 1 (or not
defined).

-- 
Thomas E. Dickey <address@hidden>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature