bug-ncurses
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure-time LDFLAGS leak into ncurses pkg-config file


From: Thomas Dickey
Subject: Re: [PATCH] configure-time LDFLAGS leak into ncurses pkg-config file
Date: Sun, 10 May 2020 17:56:45 -0400
User-agent: NeoMutt/20170113 (1.7.2)

On Thu, May 07, 2020 at 09:22:35AM +0200, Michael Stapelberg wrote:
> When building ncurses with e.g. -Wl,-rpath=/ro/ncurses-amd64-6.2-9/lib
> (to make it hermetic, see my work-in-progress post at
> https://website-review.zekjur.net/pull/hermetic/posts/2020-05-04-distri-hermetic-packages/),
> I noticed that the resulting pkg-config files (e.g.
> lib/pkgconfig/ncursesw.pc) includes the LDFLAGS!
> 
> This will result in software that links against ncurses being built
> with the wrong rpath.
> 
> In general, LDFLAGS should not be persisted into pkg-config. The
> attached patch fixes the issue.

maybe.   The problem that I'm addressing in the current script is the
fact that the various BSD systems don't provide for setting the library
path except for (a) the base system, or (b) their preferred "ports".

I'll open up this can of worms again, and check that aspect.
If that's as I recall, I'll probably just add an option which
you could use to avoid patching the script :-)

-- 
Thomas E. Dickey <address@hidden>
https://invisible-island.net
ftp://ftp.invisible-island.net

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]