Re: ANN: ncurses-6.2-20211016

[Thomas Dickey]

On Mon, Oct 25, 2021 at 12:08:15PM +0200, Milan P. Stanić wrote:
> On Sun, 2021-10-24 at 17:12, Thomas Dickey wrote:
> > ----- Original Message -----
> > | From: "Milan P. Stanić" <mps@arvanta.net>
> > | To: "Thomas Dickey" <dickey@his.com>
> > | Cc: "Ncurses Mailing List" <bug-ncurses@gnu.org>
> > | Sent: Sunday, October 24, 2021 4:45:19 PM
> > | Subject: Re: ANN: ncurses-6.2-20211016
> > 
> > | On Sun, 2021-10-24 at 16:25, Thomas Dickey wrote:
> > |> ----- Original Message -----
> > |> | From: "Milan P. Stanić" <mps@arvanta.net>
> > |> | To: "Thomas Dickey" <dickey@his.com>
> > |> | Cc: "Ncurses Mailing List" <bug-ncurses@gnu.org>
> > |> | Sent: Sunday, October 24, 2021 4:21:33 PM
> > |> | Subject: Re: ANN: ncurses-6.2-20211016
> > |> 
> > |> | On Sun, 2021-10-24 at 15:28, Thomas Dickey wrote:
> > |> |> On Sun, Oct 24, 2021 at 08:23:04PM +0200, Milan P. Stanić wrote:
> > |> |> > On Sun, 2021-10-24 at 13:44, Thomas Dickey wrote:
> > |> |> > > ----- Original Message -----
> > |> |> > > | From: "Milan P. Stanić" <mps@arvanta.net>
> > |> |> > > | To: "Ncurses Mailing List" <bug-ncurses@gnu.org>
> > |> |> > > | Sent: Sunday, October 24, 2021 8:18:25 AM
> > |> |> > > | Subject: Re: ANN: ncurses-6.2-20211016
> > |> |> > > 
> > |> |> > > | Hi Thomas,
> > |> |> > > | 
> > |> |> > > | On Sun, 2021-10-17 at 00:26, Thomas Dickey wrote:
> > |> |> > > | [...]
> > |> |> > > | 
> > |> |> > > |> 20211016
> > |> |> > > |>        + build-fix for pmake with libtool.
> > |> |> > > |>        + improve make-tar.sh scripts, adding COPYING to tar 
> > file, and clean up
> > |> |> > > |>          shellcheck warnings.
> > |> |> > > |>        + add link for "reset6" manpage in test-package 
> > ncurses6-doc
> > |> |> > > |>        + revise configure option --with-pkg-config-libdir, 
> > using the actual
> > |> |> > > |>          search path from pkg-config or pkgconf using the 
> > output from --debug
> > |> |> > > |>          (report by Pascal Pignard).
> > |> |> > > 
> > |> |> > > https://invisible-island.net/ncurses/NEWS.html#t20211017
> > |> |> > > 
> > |> |> > >         + amend change for pkg-config to account for "none" being 
> > returned in
> > |> |> > >           the libdir-path result rather than "no" (report by 
> > Gabriele Balducci).
> > |> |> > 
> > |> |> > Yes, my build log below is when building 6.2-20211017
> > |> |> > 
> > |> |> > Our option is only to make patch for configure to pass builders
> > |> |> 
> > |> |> for now - I'll have to sort it out and find a better solution
> > |> |>  
> > |> |> > > | 
> > |> |> > > | this changes in configure introduced bug in Alpine linux 
> > builders
> > |> |> > > | because they don't have /usr/lib/pkgconfig dir by default.
> > |> |> > > | 
> > |> |> > > | Here is part of  ./configure log:
> > |> |> > > | -------------------------------------
> > |> |> > > | checking for long file names... yes
> > |> |> > > | checking if you want to use pkg-config... yes
> > |> |> > > | checking for x86_64-alpine-linux-musl-pkg-config... no
> > |> |> > > | checking for pkg-config... /usr/bin/pkg-config
> > |> |> > > | checking for /usr/bin/pkg-config library directory... checking 
> > for first
> > |> |> > > | directory... none
> > |> |> > > | checking if we should install .pc files for 
> > /usr/bin/pkg-config... yes
> > |> |> > > | configure: error: expected a pathname, not ""
> > |> |> 
> > |> |> I think that the fix for this may be small :-)
> > |> | 
> > |> | Would you mind to post this fix? I'm not much versed in
> > |> | autoconf/configure and have 'fear' to make something bad for ncurses on
> > |> | alpine linux now when we are in 'freeze' for next stable release.
> > |> 
> > |> Just before your mail, I sent a small patch which you could try,
> > |> to verify that my proposed fix also works for you.  (I tested it
> > |> here by renaming my "pkgconfig" directories to simulate the effect
> > |> of not having any).
> > | 
> > | Thanks for fast fix.
> > | Applied it and it works. I will test it more tomorrow because I'm tired
> > | now (I'm in CET tz).
> > 
> > sounds good - I can wait til you've checked it tomorrow, before making that 
> > a regular update.
> 
> With patch you posted last night it builds but it puts .pc files in
> wrong dir, i.e. root install dir (in alpine case id pkg/ncurses)
> instead of $libdir/usr/lib/pkgconfig

hmm - the drawback that I knew of was that it would pick the first directory
scanned (which isn't necessarily the one most often used).  Standardization
across pkg-config's always been very poor, so I've machines with all of the
choices being used by one package or another.

To recap, the current issue was begun by a report that the existing
(Debian-biased) predefined list of directories wasn't suitable.

The manual page mentions

       --variable=VARIABLENAME
              This  returns the value of a variable defined in a package's .pc
              file. Most packages define the variable "prefix",  for  example,
              so you can say:
                $ pkg-config --variable=prefix glib-2.0
                /usr/

and I overlooked its usefulness for the task (because the manual page doesn't
point out the relationship between "pc_path", PKG_CONFIG_PATH and
PKG_CONFIG_LIBDIR (actually reading the source code is needed to see the
distinction between the latter two):

       pc_path
              The default search path used by pkg-config  when  searching  for
              .pc files. This can be used in a query for the pkg-config module
              itself itself:
                $ pkg-config --variable pc_path pkg-config

Using "pkg-config --variable=pc_path" gives me this:

/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig

which needs some work to make it usable when developing a package.

(I did read about "pkgconf" while working on the macro -- because I tested it
with the BSDs which generally don't use pkg-config -- and the point was
made in _its_ documentation that one should not actually count on it being
compatible in fine details).

fwiw, I test with machines older than 15 years as well...

-- 
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature