Re: [Evms-devel] userspace discovery of partitions

[Andrew Clausen]

On Tue, Jan 01, 2002 at 01:18:17PM -0700, Andreas Dilger wrote:
> On Jan 02, 2002  05:57 +1100, Andrew Clausen wrote:
> > As discussed a while ago (see thread starting at
> > http://www.uwsg.iu.edu/hypermail/linux/kernel/0105.2/0659.html), I
> > wrote a frontend to libparted that does nothing but probe all
> > block devices for partition tables, and tells the kernel what
> > partitions it finds.  It optionally prints a short summary.
> 
> This would mesh nicely with the filesystem (and other content) probing
> tool/lib that I wrote, blkid.  It probes filesystem types (and also
> label, uuid, fs size for common fs types).

Indeed.  To be honest, I think it's a mistake to have both libparted
and blkid.  OTOH, libparted isn't scaling down very well (yet).

> Hmm, it does seem a bit large for what it is doing.  Any idea where
> the bloat is coming from?

Mainly because the code is structured for editing.  Editing is much
harder than just reading.  There is a lot more information to parse,
that you could otherwise throw out.  For example, you don't care about
partition names, or whether the partition has some magic flag to
allow it to boot on architecture X.

Also, since you must provide an incremental editing system when
editting, it is often easier to use this system when you are
parsing.  That means you can't get rid of the editing system when
all you want to do is parse.  In libparted, this includes a
constraint solver (about 7k), code to verify that there's space
for metadata, code to set partition types, flags...

In practice, all this code is hard to separate out, and it all
adds up.  Perhaps this is an argument for maintaining two sets of
partition code.  Feel free to look at the code, and decide for
yourself ;)

Andrew