Re: gcc bug causes parted to write bad GPT entries

[Richard Hirst]

On Mon, Mar 18, 2002 at 11:48:18AM +0000, Richard Hirst wrote:
> The GUIDs are on disk in LE byte order, libuuid works in BE byte order.
> 
> Options:
> 
> 1. Leave code as is, but add cpu_to_be()/be_to_cpu() swapping round calls
> to libuuid.  Could just have be_to_cpu() after uuid_generate(), and have
> local parse_le() unparse_le() functions.

Checking the archives, I see Matt Domsch sent a variant of this:

http://domsch.com/linux/patches/parted/parted-1.4.23-gpt-swab.patch

back in January, but it wasn't included in 1.4.24.  It actaully looks
broken to me, because it just byteswaps regardless of local CPU byte
order.  Anyway, perhaps that indicates a preference for my option 1.

So now we have a chioce of

a) a fixed version of Matt's patch plus my gcc bug workaround
b) my option 2 (manage as big-endian arrays of bytes throughout)

Richard