PATCH: (updated) add hp-service partition support

[Richard Hirst]

Hi,
  This is an updated version of my patch for HP service partition
support, for parted 1.4.  If should apply cleanly on top of the
big-endian patch I just posted.  There are no code changes from the
last version I posted.

With respect to the discussion about whether this should be called
hp-diag, and whether it should be one flag or two seperate ones, or
supported via a new 'partition label' concept, I would like to propse
that we apply this to 1.4, and figure out how to do it right for 1.6.
I will rework by big-endian patch, and this one (if appropriate) for
1.6, assuming they are accepted for 1.4.

Cheers,
  Richard


diff -ur parted-1.4.24.ori+le1/ChangeLog 
parted-1.4.24.ori+le1+hpservice/ChangeLog
--- parted-1.4.24.ori+le1/ChangeLog     Tue Mar 19 19:01:51 2002
+++ parted-1.4.24.ori+le1+hpservice/ChangeLog   Tue Mar 19 19:05:16 2002
@@ -13,6 +13,7 @@
   now gets unique GUID byte order correct, and works on big-endian
 * treat GUIDs as little-endian blobs except when calling libuuid functions,
   avoid triggering gcc ((packed)) bug
+* add hp-service partition type support
 
 2002-01-26  Andrew Cluasen  <address@hidden>
 * added new/updated translations: ca, fr, da
diff -ur parted-1.4.24.ori+le1/doc/API parted-1.4.24.ori+le1+hpservice/doc/API
--- parted-1.4.24.ori+le1/doc/API       Tue Jun  5 01:06:34 2001
+++ parted-1.4.24.ori+le1+hpservice/doc/API     Tue Mar 19 19:04:27 2002
@@ -547,7 +547,8 @@
        PED_PARTITION_HIDDEN=4,
        PED_PARTITION_RAID=5,
        PED_PARTITION_LVM=6,
-       PED_PARTITION_LBA=7
+       PED_PARTITION_HPSERVICE=7,
+       PED_PARTITION_LBA=8
 } PedPartitionFlag;
 #define PED_PARTITION_FIRST_FLAG        PED_PARTITION_BOOT
 #define PED_PARTITION_LAST_FLAG         PED_PARTITION_LBA
diff -ur parted-1.4.24.ori+le1/doc/USER parted-1.4.24.ori+le1+hpservice/doc/USER
--- parted-1.4.24.ori+le1/doc/USER      Tue Oct 16 18:36:04 2001
+++ parted-1.4.24.ori+le1+hpservice/doc/USER    Tue Mar 19 19:04:27 2002
@@ -339,7 +339,7 @@
 select DEVICE                 choose the device to edit
 set MINOR FLAG STATE          change a flag on partition MINOR
 
-FLAG is one of: boot, root, swap, hidden, raid, lvm, lba
+FLAG is one of: boot, root, swap, hidden, raid, lvm, lba, hp-service
 
 FS-TYPE is one of: ext2, FAT, hfs, linux-swap, ntfs, reiserfs
 
diff -ur parted-1.4.24.ori+le1/doc/parted.8 
parted-1.4.24.ori+le1+hpservice/doc/parted.8
--- parted-1.4.24.ori+le1/doc/parted.8  Fri Apr 27 00:20:02 2001
+++ parted-1.4.24.ori+le1+hpservice/doc/parted.8        Tue Mar 19 19:04:27 2002
@@ -102,7 +102,8 @@
 .TP
 .B set \fIpartition\fP \fIflag\fP \fIstate\fP
 change the state of the \fIflag\fP on \fIpartition\fP to \fIstate\fP. Flags
-supported are: "boot", "root", "swap", "hidden", "raid", "lvm" and "lba".
+supported are: "boot", "root", "swap", "hidden", "raid", "lvm", "lba" and
+"hp-service".
 \fIstate\fP should be either "on" or "off"
 .RS
 .SH REPORTING BUGS
diff -ur parted-1.4.24.ori+le1/include/parted/disk.h 
parted-1.4.24.ori+le1+hpservice/include/parted/disk.h
--- parted-1.4.24.ori+le1/include/parted/disk.h Tue Sep 11 07:52:34 2001
+++ parted-1.4.24.ori+le1+hpservice/include/parted/disk.h       Tue Mar 19 
19:04:27 2002
@@ -52,7 +52,8 @@
        PED_PARTITION_HIDDEN=4,
        PED_PARTITION_RAID=5,
        PED_PARTITION_LVM=6,
-       PED_PARTITION_LBA=7
+       PED_PARTITION_HPSERVICE=7,
+       PED_PARTITION_LBA=8
 } PedPartitionFlag;
 #define PED_PARTITION_FIRST_FLAG       PED_PARTITION_BOOT
 #define PED_PARTITION_LAST_FLAG                PED_PARTITION_LBA
diff -ur parted-1.4.24.ori+le1/include/parted/disk_gpt.h 
parted-1.4.24.ori+le1+hpservice/include/parted/disk_gpt.h
--- parted-1.4.24.ori+le1/include/parted/disk_gpt.h     Tue Mar 19 19:02:20 2002
+++ parted-1.4.24.ori+le1+hpservice/include/parted/disk_gpt.h   Tue Mar 19 
19:06:13 2002
@@ -75,6 +75,8 @@
     EFI_GUID(0xe6d6d379, 0xf507, 0x44c2, 0xa2, 0x3c, 0x23, 0x8f, 0x2a, 0x3d, 
0xf9, 0x28)
 #define PARTITION_RESERVED_GUID \
     EFI_GUID(0x8da63339, 0x0007, 0x60c0, 0xc4, 0x36, 0x08, 0x3a, 0xc8, 0x23, 
0x09, 0x08)
+#define PARTITION_HPSERVICE_GUID \
+    EFI_GUID(0xe2a1e728, 0x32e3, 0x11d6, 0xa6, 0x82, 0x7b, 0x03, 0xa0, 0x00, 
0x00, 0x00)
 
 
 /* NOTE: The following structure is _always_ in little-endian format,
diff -ur parted-1.4.24.ori+le1/libparted/disk.c 
parted-1.4.24.ori+le1+hpservice/libparted/disk.c
--- parted-1.4.24.ori+le1/libparted/disk.c      Mon Oct  1 22:36:48 2001
+++ parted-1.4.24.ori+le1+hpservice/libparted/disk.c    Tue Mar 19 19:04:27 2002
@@ -1809,6 +1809,8 @@
                return N_("lvm");
        case PED_PARTITION_LBA:
                return N_("lba");
+       case PED_PARTITION_HPSERVICE:
+               return N_("hp-service");
 
        default:
                ped_exception_throw (
diff -ur parted-1.4.24.ori+le1/libparted/disk_gpt.c 
parted-1.4.24.ori+le1+hpservice/libparted/disk_gpt.c
--- parted-1.4.24.ori+le1/libparted/disk_gpt.c  Tue Mar 19 19:02:20 2002
+++ parted-1.4.24.ori+le1+hpservice/libparted/disk_gpt.c        Tue Mar 19 
19:04:27 2002
@@ -1615,6 +1615,15 @@
                                PARTITION_BASIC_DATA_GUID;
 
                break;
+       case PED_PARTITION_HPSERVICE:
+               if (state)
+                       gpt_part_data->pte->PartitionTypeGuid =
+                               PARTITION_HPSERVICE_GUID;
+               else
+                       gpt_part_data->pte->PartitionTypeGuid =
+                               PARTITION_BASIC_DATA_GUID;
+
+               break;
        case PED_PARTITION_LBA:
                if (!state) return 0;
                break;
@@ -1649,6 +1658,9 @@
        case PED_PARTITION_LVM:
                return (!efi_guidcmp(gpt_part_data->pte->PartitionTypeGuid, 
                                     PARTITION_LVM_GUID));
+       case PED_PARTITION_HPSERVICE:
+               return (!efi_guidcmp(gpt_part_data->pte->PartitionTypeGuid, 
+                                    PARTITION_HPSERVICE_GUID));
        case PED_PARTITION_BOOT:
                return (!efi_guidcmp(gpt_part_data->pte->PartitionTypeGuid,
                                     PARTITION_SYSTEM_GUID));
@@ -1671,6 +1683,7 @@
        case PED_PARTITION_RAID:
        case PED_PARTITION_LVM:
        case PED_PARTITION_LBA:
+       case PED_PARTITION_HPSERVICE:
        case PED_PARTITION_BOOT:
                return 1;
        case PED_PARTITION_ROOT: