address@hidden: Bug#172662: libparted1.6-0: please don't call sgi disklabels mips disklabels]

[Timshel Knoll]

Hiya bug-parted-ers!

Andrew,

Just recieved this bug report. I've fixed the Debian stuff, the only
other thing is the patch to disk_mips.c right at the bottom of the diff.
I assume that there are other references to MIPS disklabels in the
documentation, too ...

Cheers,

Timshel

----- Forwarded message from Guido Guenther <address@hidden> -----

Subject: Bug#172662: libparted1.6-0: please don't call sgi disklabels mips 
disklabels
Reply-To: Guido Guenther <address@hidden>,
        address@hidden
Date: Wed, 11 Dec 2002 18:37:58 +0100
From: Guido Guenther <address@hidden>
To: Debian Bug Tracking System <address@hidden>
Message-ID: <address@hidden>
User-Agent: Mutt/1.4i
X-Spam-Status: No, hits=-5.2 required=5.0
        tests=PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01,USER_AGENT,
              USER_AGENT_MUTT
        version=2.41

Package: libparted1.6-0
Version: 1.6.3-3
Severity: wishlist
Tags: patch

Hi,
calling the SGI disklabels mips disklabels is incorrect since only SGI
based mips machines use these disklabels (no other mips based machines
use this kind of disklabels - and there are lots of them). Better names
would be either Irix or SGI disklabels (fdisk uses both names). Attached
patch changes the name in the package descriptions to SGI and in
libparted itself to 'sgi-mips'.  Any chance to change the name?
Regards,
 -- Guido

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux bogon 2.4.18-bogon #1 Son Mai 19 19:04:57 CEST 2002 i686
Locale: address@hidden, address@hidden

--- debian/control.orig Wed Dec 11 18:27:07 2002
+++ debian/control      Wed Dec 11 18:26:35 2002
@@ -19,7 +19,7 @@
  disk usage, and copying data to new hard disks. This package
  contains the Parted binary and manual page.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -56,7 +56,7 @@
  less cosmetical features resulting in smaller binary. Intended
  to be used on boot floppies.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -89,7 +89,7 @@
  This package contains libparted, the required shared library
  used by Parted.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -123,7 +123,7 @@
  This package contains the i18n message catalogs for
  libparted and parted.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -156,7 +156,7 @@
  for libparted, which are really only of interest to parted
  developers.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -192,7 +192,7 @@
  The debugging libraries are installed as /usr/lib/libparted_g.a
  Link specifically with them if you want to debug.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
--- debian/control.in.orig      Wed Dec 11 18:25:27 2002
+++ debian/control.in   Wed Dec 11 18:24:57 2002
@@ -19,7 +19,7 @@
  disk usage, and copying data to new hard disks. This package
  contains the Parted binary and manual page.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -56,7 +56,7 @@
  less cosmetical features resulting in smaller binary. Intended
  to be used on boot floppies.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -89,7 +89,7 @@
  This package contains libparted, the required shared library
  used by Parted.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -123,7 +123,7 @@
  This package contains the i18n message catalogs for
  libparted and parted.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -156,7 +156,7 @@
  for libparted, which are really only of interest to parted
  developers.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
@@ -192,7 +192,7 @@
  The debugging libraries are installed as /usr/lib/libparted_g.a
  Link specifically with them if you want to debug.
  .
- Parted currently supports DOS, Mac, Sun, BSD, GPT, MIPS and
+ Parted currently supports DOS, Mac, Sun, BSD, GPT, SGI and
  PC98 disklabels/partition tables, as well as a 'loop' (raw
  disk) type which allows use on RAID/LVM. Filesystems which
  are currently fully supported are ext2, ext3, fat (FAT16
--- libparted/disk_mips.c.orig  Wed Dec 11 12:13:54 2002
+++ libparted/disk_mips.c       Wed Dec 11 12:14:00 2002
@@ -905,7 +905,7 @@
 
 static PedDiskType mips_disk_type = {
        next:           NULL,
-       name:           "mips",
+       name:           "sgi-mips",
        ops:            &mips_disk_ops,
        features:       PED_DISK_TYPE_PARTITION_NAME | PED_DISK_TYPE_EXTENDED
 };


----- End forwarded message -----

-- 
Timshel Knoll <address@hidden>, Debian email: <address@hidden>
Debian GNU/Linux developer: http://people.debian.org/~timshel/
GnuPG public key: finger address@hidden

pgpvmNaBTEhSi.pgp
Description: PGP signature