[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for GNU/Hurd.
From: |
Jeroen Dekkers |
Subject: |
Re: Patch for GNU/Hurd. |
Date: |
Sun, 23 May 2004 23:05:23 +0200 |
User-agent: |
Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.3.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Sun, 23 May 2004 07:52:56 -0500,
Harley D. Eades III wrote:
> Hi,
> I have been investigating a problem with parted on GNU/Hurd. The
> problem was a simple one,
> when a user supplied a path parted would segfault. It works fine if you
> use the TYPE:NAME syntax.
> The problem was you strictly use store_typed_open which only allows the
> TYPE:NAME syntax. I added
> a small check to see if the user supplies a path or the TYPE:NAME
> syntax. If it is a path use the store_open
> function, if it is TYPE:NAME use store_typed_open. You will notice in
> the patch all I do is check to see if
> there is a '/' in path. This might not be as sexy of a check feel free
> to change it. This is just a simple fix.
I think it's better to check for the ':' and then call
store_typed_open. If you use parted on a filesystem image in the
current work directory it won't have a '/' and therefore it won't work
if you check for '/'. And having a path with a semicolon is very
unlikely so this way it will work probably better.
Jeroen Dekkers
- Patch for GNU/Hurd., Harley D. Eades III, 2004/05/23
- Re: Patch for GNU/Hurd.,
Jeroen Dekkers <=