|
From: | Woody Suwalski |
Subject: | Re: Removing "pointless" exception for exotic block devices causes probe to find CDs |
Date: | Sun, 05 Dec 2004 11:39:27 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041202 Debian/1.7.3.x.1-39 |
Andrew Clausen wrote:
Probably it would work. I have an application walking ped_disks structure, so will need to change it's logic (it is similar to Colin's problem). Maybe next version...On Sat, Dec 04, 2004 at 10:02:40AM -0500, Woody Suwalski wrote:I have mentioned the same problem to Andrew long time ago....I suggested restoring (inside parted) checking if the IOCTL GetGeometry fails. If it fails: either it is a CD drive, or device which parted should not touch either, so the disk should not be added to the list.For now I have implemented a simpler patch - disabled inside parted a call to "probe_standard_devices", so that what is left is /proc/partition info. Works for me - no CD drives there...Is there any reason why checking "dev->read_only" wouldn't work? Cheers, Andrew
Still there is no point in including in the parted's disk list CDROMs or devices with no geometry... None of these will ever be used as a repartitioning target...
Woody
[Prev in Thread] | Current Thread | [Next in Thread] |