[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ok to commit ubd patch ?

From: Andrew Clausen
Subject: Re: Ok to commit ubd patch ?
Date: Sun, 19 Dec 2004 09:43:25 +1100
User-agent: Mutt/1.3.28i

On Sat, Dec 18, 2004 at 09:31:03PM +0100, Sven Luther wrote:
> It doesn't seems to be part of 1.6.20 though, an oversight ? 

It was an oversight.

However, looking at it again, I have decided to change
_device_probe_type() to set PED_DEVICE_UNKNOWN rather than
PED_DEVICE_FILE for block devices that are not in one of the
existing major categories.  This means the kernel gets notified
correctly of partition table changes.

I'm not sure how useful it is having a long list of PedDeviceType...
Are there any arguments in favour of PED_DEVICE_UBD?  Remember,
libparted is supposed to be portable...

(Actually, it wasn't my idea in the first place.  If it were me,
I would have left PedDeviceType out all together)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]