[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

reiser4 filesystem detection

From: B.Hakvoort
Subject: reiser4 filesystem detection
Date: Tue, 28 Dec 2004 16:57:05 +0100

Hi ppl,

I've just implemented reiser4 detection in libparted. That is, i copied
and modified the ntfs detectionpart. It all seems to work fine, but i'd
like to make a few things clear before sending patches.

Why do the specific probefunctions (e.g. ntfs_probe in fs_ntfs/ntfs.c)
return a PedGeometry? I've skimmed through the probe-sections in
filesys.c and figured it has something to do with the heuristics, but i
can't see why a simple boolean wouldn't suffice. 'true' if geom contains
fs signature, 'false' if not.
Or maybe an integer to assign 'scores' to a filesystem...

Second, atm i just return a copy of 'geom' when reiser4 signature is
found. This works fine, but i've noticed all the other filesystems
return different lenghts (e.g. ntfs used 'PED_LE64_TO_CPU
(*(uint64_t*)(buf + 0x28))' to calculate the lenght of the new geom)

It would be cool if someone could explain this to me, so i can add
reiser4 detection to libparted (and when that's done reiser4 support to
gparted ;) )


www.titanium-it.nl --- Open Minded Open Source
www.heavenisopen.com <-----Another Source

reply via email to

[Prev in Thread] Current Thread [Next in Thread]